[Templating] added the private parameter in the TemplateController example
#13104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Feb 12, 2020
| @@ -494,6 +497,8 @@ provided by Symfony: | |||
| <!-- special options defined by Symfony to set the page cache --> | |||
| <default key="maxAge">86400</default> | |||
| <default key="sharedAge">86400</default> | |||
| <!-- Whether or not caching should apply for client caches only --> | |||
There was a problem hiding this comment.
Suggested change
| <!-- Whether or not caching should apply for client caches only --> | |
| <!-- whether or not caching should apply for client caches only --> |
|
One question, is this a new feature introduced in 5.0 or was it just missing? |
HeahDude
approved these changes
Feb 17, 2020
HeahDude
changed the title
private parameter in the TemplateController example
|
Thank you! I've merged in 4.4 and applied the cs changes. |
HeahDude
added a commit
that referenced
this pull request
Feb 18, 2020
…lateController example (zairigimad) This PR was submitted for the 5.0 branch but it was squashed and merged into the 4.4 branch instead (closes #13104). Discussion ---------- [Templating] added the `private` parameter in the TemplateController example Commits ------- 9e4f7ab [Templating] added the `private` parameter in the TemplateController example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.